[Utils] Replace preserve_attr with patch_attr
#1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Sayers <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
kylesayrs
changed the title
preserve_attr with patch_attrpreserve_attr with patch_attr
| @@ -1132,9 +1132,39 @@ def calibration_forward_context(model: PreTrainedModel): | |||
|
|
|||
|
|
|||
| @contextlib.contextmanager | |||
| def preserve_attr(base: object, attr: str): | |||
| value = getattr(base, attr) | |||
| def patch_attr(base: object, attr: str, *args, **kwargs): | |||
There was a problem hiding this comment.
why use *args and **kwargs here? It seems like you can just have a patch_value: Any = None input rather than trying to infer based on len(args) or "value" in kwargs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
preserve_attrunittest.mock.patch, except that using this functionality does not require using theunittestlibrary in source codeChanges
preserve_attrwithpatch_attrsrc/llmcompressor/pipelines/sequential/helpers.py, which helps with clarityTesting